zabetak commented on a change in pull request #1257: [CALCITE-3115] Add
JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet
URL: https://github.com/apache/calcite/pull/1257#discussion_r291398786
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
##########
@@ -270,7 +270,7 @@ public JdbcJoinRule(JdbcConvention out) {
public JdbcJoinRule(JdbcConvention out,
RelBuilderFactory relBuilderFactory) {
super(Join.class, (Predicate<RelNode>) r -> true, Convention.NONE,
- out, relBuilderFactory, "JdbcJoinRule");
+ out, relBuilderFactory, "JdbcJoinRule:" + out);
Review comment:
I have the impression that JdbcConvention#toString() may return a String
that does not obey the description pattern of the rule and thus get a
RuntimeException when instantiating the rule. Is it possible? Should we
normalize somehow the string obtained from the convention?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
