DonnyZone commented on a change in pull request #1279: [CALCITE-3128] Joining
two tables producing only NULLs will return 0 …
URL: https://github.com/apache/calcite/pull/1279#discussion_r297523893
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -1113,7 +1121,14 @@ public boolean moveNext() {
final TSource outer = outers.current();
final Enumerable<TInner> innerEnumerable;
if (outer == null) {
- innerEnumerable = null;
Review comment:
Since the `innerLookup` has only one entry (maybe `EmptyList` or some
constant numbers in `Linq4jTest.ONE_SELECTOR`, etc.), can we just remove the
branch (`outer==null`) to avoid introducing the variable
`isConditionAlwaysTrue`? The logic in `else` branch can handle this case as the
`outerKey` is also `EmptyList`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
