DonnyZone commented on a change in pull request #1279: [CALCITE-3128] Joining
two tables producing only NULLs will return 0 …
URL: https://github.com/apache/calcite/pull/1279#discussion_r297544373
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -1113,7 +1121,14 @@ public boolean moveNext() {
final TSource outer = outers.current();
final Enumerable<TInner> innerEnumerable;
if (outer == null) {
- innerEnumerable = null;
+ if (isConditionAlwaysTrue) {
+ // when the join condition is always true, the innerLookup
will always
+ // have one entry whose key is an EmptyList and value is
+ // the whole inner enumerable.
+ innerEnumerable = innerLookup.values().iterator().next();
Review comment:
Do we need to add Assertion here for double check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
