danny0405 commented on a change in pull request #1279: [CALCITE-3128] Joining
two tables producing only NULLs will return 0 …
URL: https://github.com/apache/calcite/pull/1279#discussion_r297532191
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -1113,7 +1121,14 @@ public boolean moveNext() {
final TSource outer = outers.current();
final Enumerable<TInner> innerEnumerable;
if (outer == null) {
- innerEnumerable = null;
Review comment:
We can remove the branch `outer==null` only if
1. the `outerKeySelector.apply(outer)` can handle null key,
2. and we also should match the the `outerKey` type to know if this is a
always true match,
These 2 conditions are too dependent on the implementation and can not be
guaranteed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
