hsyuan commented on a change in pull request #1281: [CALCITE-3149] RelDataType
CACHE in RelDataTypeFactoryImpl can't be garbage collected
URL: https://github.com/apache/calcite/pull/1281#discussion_r298017439
##########
File path:
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java
##########
@@ -347,7 +350,7 @@ public RelDataType createTypeWithNullability(
* @throws NullPointerException if type is null
*/
protected RelDataType canonize(final RelDataType type) {
- return CACHE.getUnchecked(type);
Review comment:
Even though CACHE's value is soft referenced, key is strong referenced, key
and value are referencing the same object. So it will never be garbage
collected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
