hsyuan commented on a change in pull request #1281: [CALCITE-3149] RelDataType
CACHE in RelDataTypeFactoryImpl can't be garbage collected
URL: https://github.com/apache/calcite/pull/1281#discussion_r298487074
##########
File path:
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java
##########
@@ -347,7 +350,7 @@ public RelDataType createTypeWithNullability(
* @throws NullPointerException if type is null
*/
protected RelDataType canonize(final RelDataType type) {
- return CACHE.getUnchecked(type);
Review comment:
It is indeed error prone. I checked all the other usages, all seem good to
me. But it is almost impossible to prevent people from writing that code in any
place, unless code reviewers are aware of the risk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
