laurentgo commented on a change in pull request #1309: [CALCITE-3183] Trimming
method for Filter rel uses wrong traitSet
URL: https://github.com/apache/calcite/pull/1309#discussion_r302657158
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
##########
@@ -105,8 +105,8 @@ private JdbcRules() {
};
static final RelFactories.FilterFactory FILTER_FACTORY =
- (input, condition) -> new JdbcRules.JdbcFilter(input.getCluster(),
- input.getTraitSet(), input, condition);
+ (input, condition, correlVariables) -> new JdbcRules.JdbcFilter(
Review comment:
Shouldn't we check if correlVariables is empty? (same as EnumerableFilter...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
