laurentgo commented on a change in pull request #1309: [CALCITE-3183] Trimming
method for Filter rel uses wrong traitSet
URL: https://github.com/apache/calcite/pull/1309#discussion_r302656739
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableRel.java
##########
@@ -27,7 +27,9 @@
*/
public interface EnumerableRel
extends RelNode {
- RelFactories.FilterFactory FILTER_FACTORY = EnumerableFilter::create;
+ RelFactories.FilterFactory FILTER_FACTORY =
Review comment:
Shouldn't we check that `correlVariables` is actually empty? Maybe add a new
create `EnumerableFilter#create()` with the 3 args?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
