julianhyde commented on a change in pull request #1309: [CALCITE-3183] Trimming
method for Filter rel uses wrong traitSet
URL: https://github.com/apache/calcite/pull/1309#discussion_r302668337
##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -1146,7 +1146,7 @@ public RelBuilder functionScan(SqlOperator operator,
* and optimized in a similar way to the {@link #and} method.
* If the result is TRUE no filter is created. */
public RelBuilder filter(RexNode... predicates) {
- return filter(ImmutableList.copyOf(predicates));
+ return filter(ImmutableList.copyOf(predicates), Collections.emptyList());
Review comment:
Actually, if it's going to end up as an `ImmutableSet` eventually, let's use
`ImmutableSet.copyOf`. (Another reason to like `ImmutableSet` is that it
preserves iteration order. If we were to use `HashSet` as the intermediate form
it would make tests non-deterministic.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
