julianhyde commented on a change in pull request #1309: [CALCITE-3183] Trimming
method for Filter rel uses wrong traitSet
URL: https://github.com/apache/calcite/pull/1309#discussion_r302677083
##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -1146,7 +1146,7 @@ public RelBuilder functionScan(SqlOperator operator,
* and optimized in a similar way to the {@link #and} method.
* If the result is TRUE no filter is created. */
public RelBuilder filter(RexNode... predicates) {
- return filter(ImmutableList.copyOf(predicates));
+ return filter(ImmutableList.copyOf(predicates), Collections.emptyList());
Review comment:
The copy might be unnecessary, but it's not easy for the called method to
know whether to make a defensive copy, because it has public and private
callers.
So the safe/sane thing to do is to get to immutable collections as early in
the process as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
