laurentgo commented on a change in pull request #1334: [CALCITE-3111] Allow
custom implementations of Correlate in RelDecorr…
URL: https://github.com/apache/calcite/pull/1334#discussion_r307862055
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##########
@@ -2310,9 +2376,9 @@ public void onMatch(RelOptRuleCall call) {
Pair.of(rexBuilder.makeLiteral(true),
"nullIndicator")));
- LogicalJoin join =
- LogicalJoin.create(left, right, joinCond,
- ImmutableSet.of(), joinType);
+ Join join =
+ (Join) relBuilder.push(left).push(right)
Review comment:
is it guaranteed to return a join?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
