laurentgo commented on a change in pull request #1334: [CALCITE-3111] Allow
custom implementations of Correlate in RelDecorr…
URL: https://github.com/apache/calcite/pull/1334#discussion_r307860552
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##########
@@ -425,7 +435,10 @@ public Frame decorrelateRel(Sort rel) {
RelCollation newCollation = RexUtil.apply(mapping, oldCollation);
final Sort newSort =
- LogicalSort.create(newInput, newCollation, rel.offset, rel.fetch);
+ (Sort) relBuilder
Review comment:
is it guaranteed that relbuilder would return a sort (for example if
newInput has already the correct collation?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
