XuQianJin-Stars commented on a change in pull request #1335: [CALCITE-3159]
Distinct can be removed for MIN/MAX/BIT_OR/BIT_AND agg…
URL: https://github.com/apache/calcite/pull/1335#discussion_r308217662
##########
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##########
@@ -1025,28 +1025,17 @@ GROUP BY sal]]>
</Resource>
<Resource name="planBefore">
<![CDATA[
-LogicalAggregate(group=[{0}], EXPR$1=[SUM($1)], EXPR$2=[MIN(DISTINCT $1)],
EXPR$3=[SUM(DISTINCT $0)])
+LogicalAggregate(group=[{0}], EXPR$1=[SUM($1)], EXPR$2=[MIN($1)],
EXPR$3=[SUM(DISTINCT $0)])
Review comment:
> The intent of this test case is to test multiple distinct agg functions.
Now it becomes only 1. So I recommend change MIN(DISTINCT comm) to SUM(DISTINCT
comm) or AVG(DISTINCT comm), so that it won't be reduced.
well, I have modified it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
