XuQianJin-Stars commented on a change in pull request #1335: [CALCITE-3159]
Distinct can be removed for MIN/MAX/BIT_OR/BIT_AND agg…
URL: https://github.com/apache/calcite/pull/1335#discussion_r312051571
##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -939,6 +940,13 @@ public AggCall min(String alias, RexNode operand) {
ImmutableList.of(), alias, ImmutableList.of(operand));
}
+ /** Creates a call to the {@code MIN} aggregate function,
+ * optionally distinct and with an alias. */
+ public AggCall min(boolean distinct, String alias, RexNode operand) {
Review comment:
> why do you need this one?
I will remove this. thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
