danny0405 commented on a change in pull request #1354: [CALCITE-482] Implement
sql and planner hints
URL: https://github.com/apache/calcite/pull/1354#discussion_r310875037
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Join.java
##########
@@ -311,6 +347,10 @@ public abstract Join copy(RelTraitSet traitSet, RexNode
conditionExpr,
public JoinInfo analyzeCondition() {
return joinInfo;
}
+
+ @Override public ImmutableList<RelHint> getHints() {
+ return hints;
+ }
Review comment:
If this `RelNode` is copied, new copied node would keep the hints, but if
you create a new node, you should pass the hints explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
