danny0405 commented on a change in pull request #1354: [CALCITE-482] Implement
sql and planner hints
URL: https://github.com/apache/calcite/pull/1354#discussion_r335297525
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java
##########
@@ -88,6 +89,7 @@ protected VolcanoRuleCall(
// implement RelOptRuleCall
public void transformTo(RelNode rel, Map<RelNode, RelNode> equiv) {
+ rel = RelOptUtil.copyRelHints(rels[0], rel);
Review comment:
I only consider to copy hints of the rule matched root node(here it is the
rels[0]), because it is hard to figure out what transformations user would do
during the rule plan re-write, so just let use manage the hints by-themselves.
What we supply is a default behavior that copy and propagate the hints in
the root node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
