trusch opened a new pull request #45: harden error parsing. URL: https://github.com/apache/calcite-avatica-go/pull/45 This adds a nil check in the error parsing of the connection code. The old code assumes that the server always sends metadata in the ErrorResponse message. Because this is an embedded message in the protobuf definition it is compiled to a pointer and can therefore be nil. I think even if setting this is manadatory (I dont know for sure) it will be useful to have more hardened error handling. Now the code will just panic and dont reveil any additional info about the problem. If this seems to be mergeable I'll add a bug id from jira and will format my commit accordingly ;-)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
