LaiZhou commented on a change in pull request #1156: [CALCITE-2973] Allow theta
joins that have equi conditions to be exec…
URL: https://github.com/apache/calcite/pull/1156#discussion_r316661758
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableJoinRule.java
##########
@@ -61,12 +61,29 @@
if (!info.isEqui() && join.getJoinType() != JoinRelType.INNER) {
Review comment:
yes, since the SEMI/ANTI join that with empty nonEquiConditions is handled
by EnumerableHashJoin, the `if` condition should handle those case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
