LaiZhou commented on a change in pull request #1156: [CALCITE-2973] Allow theta
joins that have equi conditions to be exec…
URL: https://github.com/apache/calcite/pull/1156#discussion_r317509790
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -1307,23 +1465,118 @@ private void closeInner() {
final Enumerable<TSource> outer, final Enumerable<TInner> inner,
final Function1<TSource, TKey> outerKeySelector,
final Function1<TInner, TKey> innerKeySelector) {
- return semiJoin(outer, inner, outerKeySelector, innerKeySelector, null,
true);
+ return semiEquiJoin_(outer, inner, outerKeySelector, innerKeySelector,
null,
+ true);
}
public static <TSource, TInner, TKey> Enumerable<TSource> antiJoin(
final Enumerable<TSource> outer, final Enumerable<TInner> inner,
final Function1<TSource, TKey> outerKeySelector,
final Function1<TInner, TKey> innerKeySelector,
final EqualityComparer<TKey> comparer) {
- return semiJoin(outer, inner, outerKeySelector, innerKeySelector,
comparer, true);
+ return semiEquiJoin_(outer, inner, outerKeySelector, innerKeySelector,
comparer,
+ true);
+ }
+
+ public static <TSource, TInner, TKey> Enumerable<TSource> antiJoin(
+ final Enumerable<TSource> outer, final Enumerable<TInner> inner,
+ final Function1<TSource, TKey> outerKeySelector,
+ final Function1<TInner, TKey> innerKeySelector,
+ final EqualityComparer<TKey> comparer,
+ final Predicate2<TSource, TInner> nonEquiPredicate) {
+ return semiJoin(outer, inner, outerKeySelector,
+ innerKeySelector, comparer,
+ true, nonEquiPredicate);
+ }
+
+ /**
+ * Returns elements of {@code outer} for which there is (semi-join) / is not
(anti-semi-join)
+ * a member of {@code inner} with a matching key. A specified
+ * {@code EqualityComparer<TSource>} is used to compare keys.
+ * A predicate is used to filter the join result per-row.
+ */
+ public static <TSource, TInner, TKey> Enumerable<TSource> semiJoin(
+ final Enumerable<TSource> outer, final Enumerable<TInner> inner,
+ final Function1<TSource, TKey> outerKeySelector,
+ final Function1<TInner, TKey> innerKeySelector,
+ final EqualityComparer<TKey> comparer,
+ final boolean anti,
+ final Predicate2<TSource, TInner> nonEquiPredicate) {
+ if (nonEquiPredicate == null) {
+ return semiEquiJoin_(outer, inner, outerKeySelector, innerKeySelector,
+ comparer,
+ anti);
+ } else {
+ return semiJoinWithPredicate_(outer, inner, outerKeySelector,
+ innerKeySelector,
+ comparer,
+ anti, nonEquiPredicate);
+ }
+ }
+
+ private static <TSource, TInner, TKey> Enumerable<TSource>
semiJoinWithPredicate_(
+ final Enumerable<TSource> outer, final Enumerable<TInner> inner,
+ final Function1<TSource, TKey> outerKeySelector,
+ final Function1<TInner, TKey> innerKeySelector,
+ final EqualityComparer<TKey> comparer,
+ final boolean anti,
+ final Predicate2<TSource, TInner> nonEquiPredicate) {
+
+ return new AbstractEnumerable<TSource>() {
+ public Enumerator<TSource> enumerator() {
+ // CALCITE-2909 Delay the computation of the innerLookup until the
+ // moment when we are sure
+ // that it will be really needed, i.e. when the first outer
+ // enumerator item is processed
+ final Supplier<Lookup<TKey, TInner>> innerLookup = Suppliers.memoize(
+ () ->
+ comparer == null
+ ? inner.toLookup(innerKeySelector)
+ : inner.toLookup(innerKeySelector, comparer));
+
+ final Predicate1<TSource> predicate = anti ? v0 -> {
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
