julianhyde commented on a change in pull request #1403: [CALCITE-3283]
RelSubSet's best is not existed in the set
URL: https://github.com/apache/calcite/pull/1403#discussion_r316977414
##########
File path:
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
##########
@@ -176,6 +176,14 @@
public static final CalciteSystemProperty<Boolean> TEST_SLOW =
booleanProperty("calcite.test.slow", false);
+ /**
+ * Whether to do validation within VolcanoPlanner after each rule firing.
+ * Note that doing so would significantly slow down the planning. Should only
+ * enable for unit test.
+ */
+ public static final CalciteSystemProperty<Boolean>
TEST_VALIDATE_VOLCANO_PLANNER =
+ booleanProperty("calcite.test.validate.volcano.planner", false);
Review comment:
I don't want to add too many system properties that are meaningless to
end-users.
You can add a tracer that doesn't print stuff, just controls validation.
It's dangerous to turn extra validation on in tests. The validation can
cause side-effects that cause code to work in tests, fail in production.
Another idea is to do the extra validation if asserts are enabled (`-ea`).
Run the tests with asserts enabled and disabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
