julianhyde commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#discussion_r316979955
########## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ########## @@ -176,6 +176,14 @@ public static final CalciteSystemProperty<Boolean> TEST_SLOW = booleanProperty("calcite.test.slow", false); + /** + * Whether to do validation within VolcanoPlanner after each rule firing. + * Note that doing so would significantly slow down the planning. Should only + * enable for unit test. + */ + public static final CalciteSystemProperty<Boolean> TEST_VALIDATE_VOLCANO_PLANNER = + booleanProperty("calcite.test.validate.volcano.planner", false); Review comment: Maybe not in this case, but validation CAN have side effects such as ensuring that a cache or memo is populated (e.g. `AbstractRelNode.deriveRowType()`); in production, the cache is not populated, so the code fails. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services