ihuzenko opened a new pull request #1420: [CALCITE-3297] PigToSqlAggregateRule should be applied on multi-set projection to produce an optimal plan URL: https://github.com/apache/calcite/pull/1420 Hello @julianhyde , the PigToSqlAggregateRule was affected by my additional check that I added to rel builder in scope of CALCITE-3138. At that time I thought that merging restructuring project (project which collects flattened fields back into struct [here](https://github.com/apache/calcite/blob/97d68952d467540cddddbe8350f706028001dfbf/core/src/main/java/org/apache/calcite/sql2rel/RelStructuredTypeFlattener.java#L210) ) and flattening projects added ,for example, on top of scan makes work performed by RelStructuredTypeFlattener redundant. Please look at test updates in the PR. The final expressions in projects looks really redundant for me, for example ROW($2.OTHERS.A, $2.OTHERS.B) could be simply $2.OTHERS, and other results, like flattening and collecting back results of ITEM(...) look weird.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
