zabetak commented on a change in pull request #1425: [CALCITE-3307]
PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows
URL: https://github.com/apache/calcite/pull/1425#discussion_r319438150
##########
File path: piglet/src/test/java/org/apache/calcite/test/PigRelExTest.java
##########
@@ -67,11 +68,13 @@ private void checkType(String pigExpr, Matcher<String>
rowTypeMatcher) {
@Test
public void testConstantBoolean() {
+ Assume.assumeFalse("Skip: Pig/Hadoop tests do not work on Windows",
isWindows());
Review comment:
Instead of repeating the `assumeFalse` call in every method I guess you
would achieve the same by using `@Before` or `@BeforeClass` annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
