zabetak commented on a change in pull request #1425: [CALCITE-3307]
PigRelExTest, PigRelOpTest and PigScriptTest fail on Windows
URL: https://github.com/apache/calcite/pull/1425#discussion_r319479973
##########
File path: piglet/src/test/java/org/apache/calcite/test/PigRelTestBase.java
##########
@@ -33,6 +34,11 @@ public void testSetup() throws Exception {
final FrameworkConfig config = PigRelBuilderTest.config().build();
converter = PigConverter.create(config);
}
+
+ static void skipTestsOnWindows() {
+ Assume.assumeFalse("Skip: Pig/Hadoop tests do not work on Windows",
Review comment:
(Alt) Can we move the skip condition to the `testSetup` method just above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
