hsyuan commented on a change in pull request #1433: [CALCITE-3316] Exception
while deserializing LogicalCorrelate from json string
URL: https://github.com/apache/calcite/pull/1433#discussion_r320418136
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Correlate.java
##########
@@ -108,7 +108,7 @@ public Correlate(RelInput input) {
this(
input.getCluster(), input.getTraitSet(), input.getInputs().get(0),
input.getInputs().get(1),
- new CorrelationId((Integer) input.get("correlationId")),
+ new CorrelationId((Integer) input.get("correlation")),
Review comment:
Should we keep `correlationId` and serialize `correlationId` instead of
`correlation`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
