asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting
new parameter from model to set it in HTTP host…
URL: https://github.com/apache/calcite/pull/1447#discussion_r322329449
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java
##########
@@ -62,8 +62,9 @@ public ElasticsearchSchemaFactory() {
final Map<String, Integer> coordinates =
mapper.readValue(coordinatesString,
new TypeReference<Map<String, Integer>>() { });
+ final String scheme = (String) map.get("scheme");
Review comment:
Now when I think, it seems better to introduce another config variable like
`hosts` or `nodes` which will be a JSON array of URIs:
```
hosts: ["https://127.0.0.1:443";, "http://myNode:80";]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
