asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting
new parameter from model to set it in HTTP host…
URL: https://github.com/apache/calcite/pull/1447#discussion_r322481311
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java
##########
@@ -56,14 +59,23 @@ public ElasticsearchSchemaFactory() {
try {
final String coordinatesString = (String) map.get("coordinates");
- Preconditions.checkState(coordinatesString != null,
- "'coordinates' is missing in configuration");
- final Map<String, Integer> coordinates =
mapper.readValue(coordinatesString,
- new TypeReference<Map<String, Integer>>() { });
+ final String hostsString = (String) map.get("hosts");
Review comment:
I prefer to composite this check like this:
```java
final List<String> hosts;
if (map.containsKey("coordinates")) {
hosts = ...; // // build List<String> from coordinates
} else if (map.containsKey("hosts")) {
hosts = ...; // build List<String> from hosts
} else {
throw new IllegalArgumentException("Both 'coordinates' and 'hosts' is
missing in configuration. Provide one of them.");
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
