danny0405 commented on a change in pull request #1449: [CALCITE-3302] Implement
CLASSIFIER and LAST function for MATCH_RECOG…
URL: https://github.com/apache/calcite/pull/1449#discussion_r323084891
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMatch.java
##########
@@ -202,7 +256,17 @@ private Expression
implementEmitter(EnumerableRelImplementor implementor,
result_)));
final BlockBuilder builder = new BlockBuilder();
- builder.add(Expressions.forEach(row_, rows_, builder2.toBlock()));
+
+ // Loop Length
+ final Method size = Types.lookupMethod(List.class, "size");
+
+ // fori not foreach
+ builder.add(
Review comment:
what does this `fori not foreach` mean ? Can you give more detailed explain ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
