danny0405 commented on a change in pull request #1449: [CALCITE-3302] Implement
CLASSIFIER and LAST function for MATCH_RECOG…
URL: https://github.com/apache/calcite/pull/1449#discussion_r323084181
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##########
@@ -916,6 +915,16 @@ public AggImplementor get(final SqlAggFunction
aggregation,
return aggSupplier.get();
}
+ public MatchImplementor get(final SqlMatchFunction function) {
+ final Supplier<? extends MatchImplementor> supplier = mrMap.get(function);
+ if (supplier != null) {
+ return supplier.get();
+ } else {
+ // TODO throw an exception here?
+ return null;
Review comment:
Personally i don't like the `TODOs` in the code, we better log a JIRA issue
for it if we are planning to resolve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
