danny0405 commented on a change in pull request #1453: [CALCITE-3346] Enable
some ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r326969196
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -3670,7 +3659,6 @@ private void transitiveInference(RelOptRule...
extraRules) throws Exception {
transitiveInference();
}
- @Ignore("not working")
@Test public void testTransitiveInferenceUnion3wayOr() throws Exception {
Review comment:
Yeah, these tests fetch the test sql from the xml file which is different
from the other plan tests, i kind of think this way is not that intuitive, we
can only see the test sql in the xml file. Can we do some refactoring for this
method to let each test method pass in their own test sql ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
