danny0405 commented on a change in pull request #1453: [CALCITE-3346] Enable
some ignored tests in RelOptRuleTests
URL: https://github.com/apache/calcite/pull/1453#discussion_r327459577
##########
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##########
@@ -5436,49 +5464,42 @@ LogicalProject(EXPR$0=[1])
</TestCase>
<TestCase name="testTransitiveInferenceUnion3wayOr">
<Resource name="sql">
- <![CDATA[
-select 1 from (
- select empno, deptno from sales.emp where deptno > 7 or empno < 10
- union all
- select empno, deptno from sales.emp where deptno > 10 or empno < deptno
- union all
- select empno, deptno from sales.emp where deptno > 1) d
-inner join sales.emp e on d.deptno = e.deptno ]]>
+ <![CDATA[select 1 from (select empno, deptno from sales.emp where
deptno > 7 or empno < 10 union all select empno, deptno from sales.emp where
deptno > 10 or empno < deptno union all select empno, deptno from sales.emp
where deptno > 1) d inner join sales.emp e on d.deptno = e.deptno]]>
Review comment:
Agree, @yanlin-Lynn , when you update the SQL, please make sure that sql in
the test case and xml file are totally in the same format, e.g. they break
lines in the same positions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
