wenhuitang commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327448281
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java
##########
@@ -62,10 +65,20 @@
public ProjectJoinTransposeRule(
PushProjector.ExprCondition preserveExprCondition,
RelBuilderFactory relFactory) {
- super(
- operand(Project.class,
- operand(Join.class, any())),
- relFactory, null);
+ this(
+ operand(LogicalProject.class,
+ operand(LogicalJoin.class, any())),
+ preserveExprCondition, relFactory);
+ }
+
+ /**
+ * Creates a ProjectJoinTransposeRule.
+ */
+ public ProjectJoinTransposeRule(
+ RelOptRuleOperand operand,
+ PushProjector.ExprCondition preserveExprCondition,
+ RelBuilderFactory relFactory) {
+ super(operand, relFactory, null);
Review comment:
Just as @zabetak said "I think the way to go is to allow clients to specify
their own Project, Join and RelBuilderFactory classes. I guess our default
INSTANCE of this rule should be adapted to match only LogicalProject and
LogicalJoin"
I think it's a good way, it gives more choice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
