wenhuitang commented on a change in pull request #1462:
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r327929648
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableCorrelate.java
##########
@@ -77,6 +78,13 @@ public static EnumerableCorrelate create(
@Override public EnumerableCorrelate copy(RelTraitSet traitSet,
RelNode left, RelNode right, CorrelationId correlationId,
ImmutableBitSet requiredColumns, JoinRelType joinType) {
+ // Get new collations since the Correlate has new inputs and new condition.
+ ImmutableList<RelCollation> newCollations = ImmutableList.copyOf(
+ RelMdCollation.enumerableCorrelate(
+ getCluster().getMetadataQuery(), left, right, joinType));
+ if (!newCollations.isEmpty()) {
+ traitSet = traitSet.replace(newCollations);
Review comment:
I got it, I thought too much when I tried to solve this problem. I
understood that the other enumerable join class should have right collations
too considering the CALCITE-2554. I will adjustment this PR that only update
the collations for MergeJoin or abort the rule if the new inputs of MergeJoin
are not sorted(the result of RelMdCollation.mergeJoin for new MergeJoin is
empty).
Is this the suitable solution?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
