julianhyde commented on a change in pull request #111: [CALCITE-3324] Add
create method in MetaResultSet
URL: https://github.com/apache/calcite-avatica/pull/111#discussion_r328898411
##########
File path: core/src/main/java/org/apache/calcite/avatica/Meta.java
##########
@@ -577,6 +577,12 @@ public static MetaResultSet create(String connectionId,
int statementId,
Objects.requireNonNull(signature), firstFrame, -1L);
}
+ public static MetaResultSet create(String connectionId, int statementId,
+ boolean ownStatement, Signature signature, Frame firstFrame, long
updateCount) {
+ return new MetaResultSet(connectionId, statementId, ownStatement,
+ Objects.requireNonNull(signature), firstFrame, updateCount);
+ }
+
Review comment:
If things are public it is easier for the user, harder for the maintainer.
So my inclination is always to make things private, unless there is a good
reason.
This is what I call a "drill a hole" change. Making something public without
any rationale and without tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
