julianhyde commented on a change in pull request #1477: [CALCITE-3377] HSQLDB
is case insensitive
URL: https://github.com/apache/calcite/pull/1477#discussion_r329726979
##########
File path:
core/src/main/java/org/apache/calcite/sql/dialect/HsqldbSqlDialect.java
##########
@@ -35,7 +35,8 @@
public class HsqldbSqlDialect extends SqlDialect {
public static final SqlDialect DEFAULT =
new HsqldbSqlDialect(EMPTY_CONTEXT
- .withDatabaseProduct(DatabaseProduct.HSQLDB));
+ .withDatabaseProduct(DatabaseProduct.HSQLDB)
+ .withCaseSensitive(false));
Review comment:
Not sure that a test for SQL generation (RelToSqlConverterTest) will
demonstrate a change to HSQLDB's validation behavior.
@lameyer I'm not sure that HSQLDB is case insensitive:
```
0: jdbc:hsqldb:res:scott> !connect jdbc:hsqldb:res:scott SCOTT TIGER
0: jdbc:hsqldb:res:scott> select count(*) from "EMP";
+-----------------+
| C1 |
+-----------------+
| 14 |
+-----------------+
1 row selected (0.001 seconds)
0: jdbc:hsqldb:res:scott> select count(*) from "emp";
Error: user lacks privilege or object not found: emp (state=42501,code=-5501)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
