danny0405 commented on a change in pull request #1462: 
[CALCITE-3353]ProjectJoinTransposeRule caused AssertionError when creating a 
new Join
URL: https://github.com/apache/calcite/pull/1462#discussion_r333890678
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java
 ##########
 @@ -142,13 +144,9 @@ public void onMatch(RelOptRuleCall call) {
 
     // create a new join with the projected children
     Join newJoinRel =
-        join.copy(
 
 Review comment:
   Okey, it seems to late to make the fix into the copy, because all the inputs 
collations are already wrong, but i still have strong objections on fixing 
physical traits in logical plans.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to