danny0405 commented on a change in pull request #1354: [CALCITE-482] Implement
sql and planner hints
URL: https://github.com/apache/calcite/pull/1354#discussion_r335790446
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java
##########
@@ -88,6 +89,7 @@ protected VolcanoRuleCall(
// implement RelOptRuleCall
public void transformTo(RelNode rel, Map<RelNode, RelNode> equiv) {
+ rel = RelOptUtil.copyRelHints(rels[0], rel);
Review comment:
@hsyuan, yes, i agree we should give some default strategies for copying
here, not just simplify copy without any filtering.
BTW, does `selectivity` suitable as a hint ? It is a metadata which is
varying during planning, it is non-stable, so how can it be a valid value when
we already do many re-write. Or do you mean the filter condition's selectivity
? Then user can copy them by themselves in the `FilterJoinRule`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
