yanlin-Lynn commented on a change in pull request #1516: [CALCITE-3423] Support
using CAST operation and BOOLEAN type value in table macro
URL: https://github.com/apache/calcite/pull/1516#discussion_r337360181
##########
File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java
##########
@@ -461,6 +464,43 @@ private static String q(String s) {
connection.close();
}
+ /**
+ * <p>Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-3423";>[CALCITE-3423]
+ * Support using CAST operation and BOOLEAN type value in table macro</a>. */
+ @Test public void testTableMacroWithCastOrBoolean() throws SQLException {
+ Connection connection =
+ DriverManager.getConnection("jdbc:calcite:");
+ addTableMacro(connection, Smalls.STR_METHOD);
+ // check for cast
+ ResultSet resultSet = connection.createStatement().executeQuery(
+ "select * from table(\"s\".\"str\"(MAP['a', 1, 'baz', 2], cast(1 as
bigint))) as t(n)");
+ assertThat(CalciteAssert.toString(resultSet),
+ equalTo("N={'a'=1, 'baz'=2}\n"
+ + "N=1 \n"));
+ // check for Boolean type
+ resultSet = connection.createStatement().executeQuery(
+ "select * from table(\"s\".\"str\"(MAP['a', 1, 'baz', 2], true)) as
t(n)");
+ assertThat(CalciteAssert.toString(resultSet),
+ equalTo("N={'a'=1, 'baz'=2}\n"
+ + "N=true \n"));
+ // check for nested cast
+ resultSet = connection.createStatement().executeQuery(
+ "select * from table(\"s\".\"str\"(MAP['a', 1, 'baz', 2],"
+ + "cast(cast(1 as int) as varchar(1)))) as t(n)");
+ assertThat(CalciteAssert.toString(resultSet),
+ equalTo("N={'a'=1, 'baz'=2}\n"
+ + "N=1 \n"));
+
+ resultSet = connection.createStatement().executeQuery(
Review comment:
I tried, but failed to add an implicit type coercion case.
There exists check in
[TypeCoercionImpl](https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java#L567),
which disables type coercion for table macro. Shall we update it to support
type coercion for table macro?
For example, if we add the code snippet below
```
// check for implicit type coercion
addTableMacro(connection, Smalls.VIEW_METHOD);
resultSet = connection.createStatement().executeQuery(
"select * from table(\"s\".\"view\"(5)) as t(n)");
assertThat(CalciteAssert.toString(resultSet),
equalTo("N=1\n"
+ "N=3\n"
+ "N=5\n"));
```
we'll get exception when running the case
```
org.apache.calcite.runtime.CalciteContextException: From line 1, column 25
to line 1, column 33: No match found for function signature view(<NUMERIC>)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
org.apache.calcite.runtime.Resources$ExInstWithCause.ex(Resources.java:463)
at org.apache.calcite.sql.SqlUtil.newContextException(SqlUtil.java:834)
at org.apache.calcite.sql.SqlUtil.newContextException(SqlUtil.java:819)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.newValidationError(SqlValidatorImpl.java:4880)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.handleUnresolvedFunction(SqlValidatorImpl.java:1774)
at org.apache.calcite.sql.SqlFunction.deriveType(SqlFunction.java:305)
at org.apache.calcite.sql.SqlFunction.deriveType(SqlFunction.java:218)
at
org.apache.calcite.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:5639)
at
org.apache.calcite.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:5626)
at org.apache.calcite.sql.SqlCall.accept(SqlCall.java:139)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.deriveTypeImpl(SqlValidatorImpl.java:1692)
at
org.apache.calcite.sql.validate.ProcedureNamespace.validateImpl(ProcedureNamespace.java:53)
at
org.apache.calcite.sql.validate.AbstractNamespace.validate(AbstractNamespace.java:84)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validateNamespace(SqlValidatorImpl.java:1009)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validateQuery(SqlValidatorImpl.java:969)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validateFrom(SqlValidatorImpl.java:3129)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validateFrom(SqlValidatorImpl.java:3111)
at
org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelect(SqlValidatorImpl.java:3383)
at
org.apache.calcite.sql.validate.SelectNamespace.validateImpl(SelectNamespace.java:60)
at
org.apache.calcite.sql.validate.AbstractNamespace.validate(AbstractNamespace.java:84)
```
And the implicit type coercion case is already exist in
`TableFunctionTest.testUserDefinedTableFunction4`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
