amaliujia commented on a change in pull request #1594: [CALCITE-3514]
LatticeTest fails when JdbcSchema re-computes JdbcTables
URL: https://github.com/apache/calcite/pull/1594#discussion_r347585008
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcTable.java
##########
@@ -200,6 +200,24 @@ public RelNode toRel(RelOptTable.ToRelContext context,
sourceExpressionList, flattened);
}
+ @Override public boolean equals(Object obj) {
Review comment:
O I see. So if schema name is the same then it guarantees that two tables
will be the same (e.g. no need to check the schema), in that case it would make
sense.
I mentioned every field in checking just because I made no assumption beyond
this function. Indeed "equals" not require what is checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
