vlsi commented on a change in pull request #117: Add gradle task 
'aggregateJavadocIncludingTests' that builds javadoc for both main and test
URL: https://github.com/apache/calcite-avatica/pull/117#discussion_r349449793
 
 

 ##########
 File path: build.gradle.kts
 ##########
 @@ -169,6 +169,19 @@ val javadocAggregate by tasks.registering(Javadoc::class) 
{
     setDestinationDir(file("$buildDir/docs/javadocAggregate"))
 }
 
+val javadocAggregateIncludingTests by tasks.registering(Javadoc::class) {
+    group = JavaBasePlugin.DOCUMENTATION_GROUP
+    description = "Generates aggregate javadoc for all the artifacts"
+
+    val sourceSets = allprojects
 
 Review comment:
   1) You are right, the existing `javadocAggregate` is a bit fragile too, but 
the difference there is it relies on `main` source set only (which "always" 
exists except for `ubenchmark` which is not published for now).
   
   2) The existing `javadocAggregate` has to generate a unified javadoc so the 
website could contain a single URL for all the modules. I would love to learn 
how to "merge" javadocs from per-module javadoc, but it looks like the only way 
to do that is to execute javadoc for all the input sources.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to