vlsi commented on a change in pull request #117: Add gradle task 'aggregateJavadocIncludingTests' that builds javadoc for both main and test URL: https://github.com/apache/calcite-avatica/pull/117#discussion_r349761177
########## File path: bom/build.gradle.kts ########## @@ -2,20 +2,18 @@ * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 + * The ASF licenses this file to you under the Apache License, Version 2.0 Review comment: Either I am blind or the recommendation at legal/src-headers was updated within the recent 14 hours, but I believe I did cross-check the recommendation before posting the comment. In any case it would make sense to find out the canonical header and configure it via IDE plugin: https://github.com/vlsi/vlsi-release-plugins/blob/master/plugins/ide-plugin/src/main/kotlin/com/github/vlsi/gradle/ide/IdeExtension.kt#L64-L74 It enables to automatically configure the copyright header in IDEA, so it automatically adds the proper header as new files are created. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
