julianhyde commented on a change in pull request #1587: [CALCITE-3272] Support
TUMBLE as Table Valued Function including an enumerable implementation,
stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r349966137
##########
File path: core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java
##########
@@ -90,6 +90,17 @@ public static ExplicitReturnTypeInference
explicit(SqlTypeName typeName,
*/
public static final SqlReturnTypeInference ARG0 =
new OrdinalReturnTypeInference(0);
+
+ /**
+ * Type-inference strategy whereby the result type of a table function call
is a ROW,
+ * which is combined from the operand #0(TABLE parameter)'s schema and two
+ * additional fields:
+ * 1. wstart. TIMESTAMP type to indicate a window's start.
+ * 2. wend. TIMESTAMP type to indicate a window's end.
+ */
Review comment:
use html markup (e.g. <ol>) to ensure that 1. and 2. remain on
different lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
