julianhyde commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#discussion_r349967961
########## File path: site/_docs/reference.md ########## @@ -1836,6 +1836,22 @@ Not implemented: | GROUP_ID() | Returns an integer that uniquely identifies the combination of grouping keys | GROUPING_ID(expression [, expression ]*) | Synonym for `GROUPING` +### Table-valued window functions and DESCRIPTOR. Review comment: This documentation is good, but it implies that TVFs, DESCRIPTOR and TUMBLE are tightly connected. I think you should document DESCRIPTOR separately (it's just a way to pass a name, usually a column name, to a function); TVFs are already documented; and TUMBLE is a built-in TVF that happens to be useful for streaming-type queries and happens to use DESCRIPTOR. Keep this section, but make it 'Table-valued functions'. The only built-in TVF is TUMBLE. Describe its syntax, briefly, and its purpose in streaming queries. Don't make a big deal about DESCRIPTOR and TABLE, because those are covered elsewhere in this reference. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
