amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support
TUMBLE as Table Valued Function including an enumerable implementation,
stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r350458543
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlKind.java
##########
@@ -988,17 +988,21 @@
/** The {@code ROW_NUMBER} window function. */
CUME_DIST,
- // Group functions
+ /** The {@code DESCRIPTOR}. */
+ DESCRIPTOR,
- /** The {@code TUMBLE} group function. */
+ /** The {@code TUMBLE_TABLE_FUNCTION}. */
Review comment:
I thought Sqlkind.TUMBLE will be dedicated to the built-in table-valued
function. Given another thought now, since the old TUMBLE is not deprecated
yet, so I roll back this change to make SqlKind.TUMBLE still be used to refer
the old TUMBLE.
We can change all the comments together when be ready to deprecate old
TUMBLE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
