amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support
TUMBLE as Table Valued Function including an enumerable implementation,
stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r350892843
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -2455,7 +2455,13 @@ protected void convertCollectionTable(
}
RexNode rexCall = bb.convertExpression(call);
- final List<RelNode> inputs = bb.retrieveCursors();
+ List<RelNode> inputs = new ArrayList<>();
+
+ if (rexCall.getKind() == SqlKind.TUMBLE) {
Review comment:
I removed this check here and give it a try: confirmed again Inputs will be
empty (e.g. TABLE parameter is not converted). Am I doing right to let treat
`TUMBLE` as an ordinary table function? Is it actually other place to not check
TUMBLE to make it as a ordinary table function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
