danny0405 commented on a change in pull request #1609: [CALCITE-3520] Type cast
from primitive to box is not correct
URL: https://github.com/apache/calcite/pull/1609#discussion_r352285475
##########
File path:
core/src/test/java/org/apache/calcite/adapter/enumerable/EnumUtilsTest.java
##########
@@ -67,6 +67,17 @@
assertThat(Expressions.toString(timeStampToLong),
is("org.apache.calcite.runtime.SqlFunctions.toLongOptional(x)"));
}
+
+ @Test public void testTypeFromPrimitiveToBox() {
+ final Expression intVariable =
Review comment:
It would be nice if we can add more test cases to cover all the integer data
types conversion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
