chunweilei commented on a change in pull request #1640: [CALCITE-3552] Support
MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355242549
##########
File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java
##########
@@ -900,6 +900,11 @@
@BaseMessage("Not a valid input for REGEXP_REPLACE: ''{0}''")
ExInst<CalciteException> invalidInputForRegexpReplace(String value);
+
+ @BaseMessage("Illegal error behavior ''{0}'' EXTRACTVALUE: document:
''{1}'', xpath expression:"
+ + " ''{2}''")
+ ExInst<CalciteException> illegalErrorBehaviorInExtractValueFunc(String
value, String xpath,
+ String errorBehavior);
}
Review comment:
Both `illegal` and `error` are negative, which seems redundant. Do you mean
illegal xml path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
