[GitHub] [calcite] chunweilei commented on a change in pull request #1640: [CALCITE-3552] Support MySQL ExtractValue function

[GitBox]

chunweilei commented on a change in pull request #1640: [CALCITE-3552] Support 
MySQL ExtractValue function
URL: https://github.com/apache/calcite/pull/1640#discussion_r355241884
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
 ##########
 @@ -526,6 +527,9 @@ public Expression implement(RexToLixTranslator translator, 
RexCall call,
     defineMethod(CURRENT_VALUE, BuiltInMethod.SEQUENCE_CURRENT_VALUE.method, 
NullPolicy.STRICT);
     defineMethod(NEXT_VALUE, BuiltInMethod.SEQUENCE_NEXT_VALUE.method, 
NullPolicy.STRICT);
 
+    //Xml Operators
+    defineMethod(EXTRACTVALUE, BuiltInMethod.EXTRACTVALUE.method, 
NullPolicy.ARG0);
 
 Review comment:
   Please add a space between // and xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services