ihuzenko commented on a change in pull request #1610: [CALCITE-3525]
RexSimplify: eliminate redundant rex calls in OR
URL: https://github.com/apache/calcite/pull/1610#discussion_r357999692
##########
File path: core/src/main/java/org/apache/calcite/rex/RexExecutable.java
##########
@@ -85,7 +85,7 @@ public void reduce(RexBuilder rexBuilder, List<RexNode>
constExps,
reducedValues.add(
rexBuilder.makeLiteral(value.right, value.left.getType(), true));
}
- } catch (RuntimeException e) {
+ } catch (RuntimeException | AssertionError e) {
Review comment:
The ```rexBuilder.makeLiteral(value.right, value.left.getType(), true));```
can't create literal for non-standard types, such as GEOMETRY. Since the catch
handles failed attempts maybe it's not so bad to add assertion error here. What
do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
