ihuzenko commented on a change in pull request #1610: [CALCITE-3525]
RexSimplify: eliminate redundant rex calls in OR
URL: https://github.com/apache/calcite/pull/1610#discussion_r358148775
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -1970,6 +1980,8 @@ public static void registerDefaultRules(RelOptPlanner
planner,
// Change the below to enable constant-reduction.
if (false) {
registerReductionRules(planner);
+ } else {
+ planner.addRule(ReduceExpressionsRule.FILTER_INSTANCE);
Review comment:
yes, it belongs. At least, here it will be visible that after enabling each
reduction rule one by one in future the ```if(false)``` could be safely
replaced by ```registerReductionRules(planner);```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
